GitHub/Basalt
1
0
Fork 0
Code Issues 28 Pull Requests 3 Actions Packages Projects Releases 9 Wiki Activity

bug: "addObject" function doesn't seem to do anything #102

New Issue
Open
opened 2023-12-21 12:17:21 +08:00 by ArcanoxDragon · 0 comments
ArcanoxDragon commented 2023-12-21 12:17:21 +08:00 (Migrated from github.com)
Copy Link

Describe the bug

Calling the addObject function with a directory path doesn't seem to do anything at all - custom object modules are not required.

It looks like all this function does is add the provided path to newObjects in main.lua, but newObjects is only ever visted when main.lua is first evaluated (i.e. when the module is required, before the addObject function can even be called).

To Reproduce

Steps to reproduce the behavior:

  1. Add a custom object module to a folder that has a debug print or something at the top
  2. Pass the folder to basalt.addObject("...") in a test program
  3. Run the program and observe that the custom modules are not imported

Expected behavior

The custom object modules would be imported and registered as object types in Basalt.

Checklist

  • I am running the latest version.
**Describe the bug** Calling the `addObject` function with a directory path doesn't seem to do anything at all - custom object modules are not required. It looks like all this function does is add the provided path to `newObjects` in `main.lua`, but `newObjects` is only ever visted when `main.lua` is first evaluated (i.e. when the module is `require`d, before the `addObject` function can even be called). **To Reproduce** Steps to reproduce the behavior: 1. Add a custom object module to a folder that has a debug print or something at the top 2. Pass the folder to `basalt.addObject("...")` in a test program 3. Run the program and observe that the custom modules are not imported **Expected behavior** The custom object modules would be imported and registered as object types in Basalt. **Checklist** - [x] I am running the latest version.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GitHub
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GitHub/Basalt#102
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?