bug: DEV branch; basalt.debug crashes when called inside a thread #37

New Issue

2022-10-22T13:24:29+08:00

ShreksHellraiser commented

2022-10-22 13:24:29 +08:00

(Migrated from github.com)

What happened?

Attempt to debug a thread by displaying a value using basalt.debug crashes the program.

Computercraft client

CraftOSPC

Relevant log output

I wish this was copypastable

basalt.lua:2209: Thread Error Occured - cannot resume running coroutine

2209 in eventHandler
713 in eventHandler
71 in cab (one of the minified functions)
this was in an xpcall
80 in autoUpdate

Latest Basalt Version

I use the latest stable version

### What happened? Attempt to debug a thread by displaying a value using `basalt.debug` crashes the program. ### Computercraft client CraftOSPC ### Relevant log output ```shell I wish this was copypastable basalt.lua:2209: Thread Error Occured - cannot resume running coroutine 2209 in eventHandler 713 in eventHandler 71 in cab (one of the minified functions) this was in an xpcall 80 in autoUpdate ``` ### Latest Basalt Version - [X] I use the latest stable version

NoryiE commented

2022-10-22 15:44:02 +08:00

(Migrated from github.com)

Hm, it is hard for me to reproduce the error. When i use basalt.debug inside a running thread it works fine. Also using error or "text"..nil errors as expected.

The log output you showed here tells me that the currently running thread trys to resume the thread. Can you show me the code? Full code or important code part. On pastebin/devbin or whatever.

Also a sidenote you could use basalt.logging = true this should start to log errors into a file named basaltLogs.txt - but keep an eye on file size :P

Hm, it is hard for me to reproduce the error. When i use basalt.debug inside a running thread it works fine. Also using error or "text"..nil errors as expected. The log output you showed here tells me that the currently running thread trys to resume the thread. Can you show me the code? Full code or important code part. On pastebin/devbin or whatever. Also a sidenote you could use basalt.logging = true this should start to log errors into a file named basaltLogs.txt - but keep an eye on file size :P

ShreksHellraiser commented

2022-10-23 00:58:55 +08:00

(Migrated from github.com)

Hi, here's a recreation of the crash setup, ~~this actually doesn't crash how I expected it to. I was expecting a crash upon clicking the button, but with this setup it crashes the first time the thread is ran.~~ Edited to fix this, it now crashes upon clicking the button.

local basalt = require("basalt")

local main = basalt.createFrame():setTheme({FrameBG = colors.lightGray, FrameFG = colors.black})

main:addButton():setText("Crash"):setSize("parent.w - 2", "parent.h - 2"):setPosition(2,2):onClick(function()
  os.queueEvent("anEvent")
end)

main:addThread():start(function ()
  while true do
    os.pullEvent("anEvent")
    basalt.debug(5)
  end
end)

basalt.autoUpdate()

Hi, here's a recreation of the crash setup, ~~this actually doesn't crash how I expected it to. I was expecting a crash upon clicking the button, but with this setup it crashes the first time the thread is ran.~~ Edited to fix this, it now crashes upon clicking the button. ```lua local basalt = require("basalt") local main = basalt.createFrame():setTheme({FrameBG = colors.lightGray, FrameFG = colors.black}) main:addButton():setText("Crash"):setSize("parent.w - 2", "parent.h - 2"):setPosition(2,2):onClick(function() os.queueEvent("anEvent") end) main:addThread():start(function () while true do os.pullEvent("anEvent") basalt.debug(5) end end) basalt.autoUpdate() ```

ShreksHellraiser commented

2022-10-23 01:02:13 +08:00

(Migrated from github.com)

Oh it doesn't crash how I was expecting it to because I didn't wrap the queueEvent call in a function

NoryiE commented

2022-10-23 04:26:59 +08:00

(Migrated from github.com)

Hey, thank you! This example helped me alot. It should be fixed 5cf5347

The problem was because of dynamic value also queues a event. This is now disabled by default.

Hey, thank you! This example helped me alot. It should be fixed [5cf5347](https://github.com/Pyroxenium/Basalt/commit/5cf53476adc603aa83fbe0c4ad8fb5d79e8921a1) The problem was because of dynamic value also queues a event. This is now disabled by default.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: GitHub/Basalt#37