GitHub/Basalt
1
0
Fork 0
Code Issues 28 Pull Requests 3 Actions Packages Projects Releases 9 Wiki Activity

docs: Latest 1.7 docs suggests their is a Basalt.setTheme() #54

New Issue
Closed
opened 2023-05-02 19:00:27 +08:00 by ajh123 · 2 comments
ajh123 commented 2023-05-02 19:00:27 +08:00 (Migrated from github.com)
Copy Link

** Where? **
d4c72514ef/docs/objects/Basalt.md (LL29C45-L29C45)

As the title says, the docs contain a Basalt.setTheme() function which appears to no longer exist.
When I load Basalt and run the Basalt.setTheme() from the Lua prompt (or any other file) I get the following error (even if I pass a correct table):
basalt_error

** Possible solutions **

  1. Remove the function from the docs.
  2. Update the docs to contain the new alternative.
  3. Resurrect the old setTheme() function.

** Others **
I have downloaded the recent Minified/Packed Version a few minutes ago.

** Checklist **
[ X ] I am looking at the latest version of the docs.

** Where? ** https://github.com/Pyroxenium/Basalt/blame/d4c72514ef560af88c7f7557ba6f35ddaa2dc724/docs/objects/Basalt.md#LL29C45-L29C45 As the title says, the docs contain a `Basalt.setTheme()` function which appears to no longer exist. When I load Basalt and run the `Basalt.setTheme()` from the Lua prompt (or any other file) I get the following error (even if I pass a correct table): ![basalt_error](https://user-images.githubusercontent.com/41990982/235648338-9b365c8c-95a8-4756-a299-6fe8b0998e06.PNG) ** Possible solutions ** 1. Remove the function from the docs. 2. Update the docs to contain the new alternative. 3. Resurrect the old `setTheme()` function. ** Others ** I have downloaded the recent `Minified/Packed Version` a few minutes ago. ** Checklist ** [ X ] I am looking at the latest version of the docs.
NoryiE commented 2023-05-03 00:30:58 +08:00 (Migrated from github.com)
Copy Link

Hello and thank you! I made a small mistake in my code which made setTheme and getTheme not public. Also fixed a small bug when using themes. This is fixed here: 6c235b0

Hello and thank you! I made a small mistake in my code which made setTheme and getTheme not public. Also fixed a small bug when using themes. This is fixed here: [6c235b0](https://github.com/Pyroxenium/Basalt/commit/6c235b04dfe772205281b477eb0425210bf98b35)
👍 1
ajh123 commented 2023-05-03 00:48:34 +08:00 (Migrated from github.com)
Copy Link

Yes, that worked now.

Yes, that worked now.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GitHub
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GitHub/Basalt#54
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?