GitHub/Basalt
1
0
Fork 0
Code Issues 28 Pull Requests 3 Actions Packages Projects Releases 9 Wiki Activity

Fix addObject() by renaming to addChild() #84

Merged
thesabinelim merged 3 commits from fix-add-object into master 2023-05-18 00:53:55 +08:00
Conversation 0 Commits 3 Files Changed 9 +141 -122
thesabinelim commented 2023-05-18 00:28:58 +08:00 (Migrated from github.com)
Copy Link

addObject() wasn't working because Container has add methods for all object types, of which Object is one of them. This overrides the other addObject(), which funnily enough also depends on the original addObject().

It makes sense to rename addObject() to addChild(), as well as all other child-related functions, to avoid confusion.

addObject() wasn't working because Container has add methods for all object types, of which Object is one of them. This overrides the other addObject(), which funnily enough also depends on the original addObject(). It makes sense to rename addObject() to addChild(), as well as all other child-related functions, to avoid confusion.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GitHub
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GitHub/Basalt#84
No description provided.
Delete Branch "fix-add-object"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?