refactoring and removed unused set_waste_ack

This commit is contained in:
Mikayla Fischler
2024-08-26 20:30:30 -04:00
parent 6b20445446
commit f4be6519e8
5 changed files with 8 additions and 9 deletions

View File

@@ -386,7 +386,7 @@ function coordinator.comms(version, nic, sv_watchdog)
end
-- send the auto process control configuration with a start command
---@param auto_cfg coord_auto_config configuration
---@param auto_cfg sys_auto_config configuration
function public.send_auto_start(auto_cfg)
_send_sv(PROTOCOL.SCADA_CRDN, CRDN_TYPE.FAC_CMD, {
FAC_COMMAND.START, auto_cfg.mode, auto_cfg.burn_target, auto_cfg.charge_target, auto_cfg.gen_target, auto_cfg.limits
@@ -632,11 +632,11 @@ function coordinator.comms(version, nic, sv_watchdog)
elseif cmd == UNIT_COMMAND.SET_BURN then
unit.set_burn_ack(ack)
elseif cmd == UNIT_COMMAND.SET_WASTE then
unit.set_waste_ack(ack)
-- updated by unit updates
elseif cmd == UNIT_COMMAND.ACK_ALL_ALARMS then
unit.ack_alarms_ack(ack)
elseif cmd == UNIT_COMMAND.SET_GROUP then
-- UI will be updated to display current group if changed successfully
-- updated by unit updates
else
log.debug(util.c("received unit command ack with unknown command ", cmd))
end

View File

@@ -200,7 +200,6 @@ function iocontrol.init(conf, comms, temp_scale, energy_scale)
reset_rps_ack = __generic_ack,
ack_alarms_ack = __generic_ack,
set_burn_ack = __generic_ack,
set_waste_ack = __generic_ack,
alarm_callbacks = {
c_breach = { ack = function () ack(1) end, reset = function () reset(1) end },

View File

@@ -19,9 +19,9 @@ local process = {}
local self = {
io = nil, ---@type ioctl
comms = nil, ---@type coord_comms
---@class coord_control_states
---@class sys_control_states
control_states = {
---@class coord_auto_config
---@class sys_auto_config
process = {
mode = PROCESS.INACTIVE,
burn_target = 0.0,
@@ -55,7 +55,7 @@ function process.init(iocontrol, coord_comms)
end
local ctrl_states = settings.get("ControlStates", {})
local config = ctrl_states.process ---@type coord_auto_config
local config = ctrl_states.process ---@type sys_auto_config
-- facility auto control configuration
if type(config) == "table" then