#87 check if the reactor is active on startup/reconnect before scram'ing, rps now ignores scram errors if the error is due to the reactor being inactive

reactor-plc/plc.lua

@@ -18,6 +18,10 @@ local println = util.println
 local print_ts = util.print_ts
 local println_ts = util.println_ts
 
+-- I sure hope the devs don't change this error message, not that it would have safety implications
+-- I wish they didn't change it to error on SCRAM calls if the reactor was already inactive
+local PCALL_SCRAM_MSG = "pcall: Scram requires the reactor to be active."
+
 --- RPS: Reactor Protection System
 ---
 --- identifies dangerous states and SCRAMs reactor if warranted
@@ -169,7 +173,7 @@ function plc.rps_init(reactor)
         log.info("RPS: reactor SCRAM")
 
         self.reactor.scram()
-        if self.reactor.__p_is_faulted() then
+        if self.reactor.__p_is_faulted() and (self.reactor.__p_last_fault() ~= PCALL_SCRAM_MSG) then
             log.error("RPS: failed reactor SCRAM")
             return false
         else