#146 increased timeout times and added to config files

supervisor/config.lua

@@ -6,6 +6,11 @@ config.SCADA_DEV_LISTEN = 16000
 config.SCADA_SV_LISTEN = 16100
 -- max trusted modem message distance (0 to disable check)
 config.TRUSTED_RANGE = 0
+-- time in seconds (>= 1) before assuming a remote device is no longer active
+config.PLC_TIMEOUT = 5
+config.RTU_TIMEOUT = 5
+config.CRD_TIMEOUT = 5
+
 -- expected number of reactors
 config.NUM_REACTORS = 4
 -- expected number of boilers/turbines for each reactor
@@ -15,6 +20,7 @@ config.REACTOR_COOLING = {
     { BOILERS = 1, TURBINES = 1 },  -- reactor unit 3
     { BOILERS = 1, TURBINES = 1 }   -- reactor unit 4
 }
+
 -- log path
 config.LOG_PATH = "/log.txt"
 -- log mode

supervisor/session/coordinator.lua

@@ -42,11 +42,12 @@ local PERIODICS = {
 }
 
 -- coordinator supervisor session
----@param id integer
----@param in_queue mqueue
----@param out_queue mqueue
----@param facility facility
-function coordinator.new_session(id, in_queue, out_queue, facility)
+---@param id integer session ID
+---@param in_queue mqueue in message queue
+---@param out_queue mqueue out message queue
+---@param timeout number communications timeout
+---@param facility facility facility data table
+function coordinator.new_session(id, in_queue, out_queue, timeout, facility)
     local log_header = "crdn_session(" .. id .. "): "
 
     local self = {
@@ -57,7 +58,7 @@ function coordinator.new_session(id, in_queue, out_queue, facility)
         seq_num = 0,
         r_seq_num = nil,
         connected = true,
-        conn_watchdog = util.new_watchdog(5),
+        conn_watchdog = util.new_watchdog(timeout),
         last_rtt = 0,
         -- periodic messages
         periodics = {

supervisor/session/plc.lua

@@ -46,15 +46,15 @@ local PERIODICS = {
 }
 
 -- PLC supervisor session
----@param id integer
----@param for_reactor integer
----@param in_queue mqueue
----@param out_queue mqueue
-function plc.new_session(id, for_reactor, in_queue, out_queue)
+---@param id integer session ID
+---@param for_reactor integer reactor ID
+---@param in_queue mqueue in message queue
+---@param out_queue mqueue out message queue
+---@param timeout number communications timeout
+function plc.new_session(id, for_reactor, in_queue, out_queue, timeout)
     local log_header = "plc_session(" .. id .. "): "
 
     local self = {
-        id = id,
         for_reactor = for_reactor,
         in_q = in_queue,
         out_q = out_queue,
@@ -70,7 +70,7 @@ function plc.new_session(id, for_reactor, in_queue, out_queue)
         connected = true,
         received_struct = false,
         received_status_cache = false,
-        plc_conn_watchdog = util.new_watchdog(3),
+        plc_conn_watchdog = util.new_watchdog(timeout),
         last_rtt = 0,
         -- periodic messages
         periodics = {
@@ -248,7 +248,7 @@ function plc.new_session(id, for_reactor, in_queue, out_queue)
         local s_pkt = comms.scada_packet()
         local r_pkt = comms.rplc_packet()
 
-        r_pkt.make(self.id, msg_type, msg)
+        r_pkt.make(for_reactor, msg_type, msg)
         s_pkt.make(self.seq_num, PROTOCOLS.RPLC, r_pkt.raw_sendable())
 
         self.out_q.push_packet(s_pkt)
@@ -503,7 +503,7 @@ function plc.new_session(id, for_reactor, in_queue, out_queue)
     -- PUBLIC FUNCTIONS --
 
     -- get the session ID
-    function public.get_id() return self.id end
+    function public.get_id() return id end
 
     -- get the session database
     function public.get_db() return self.sDB end

supervisor/session/rtu.lua

@@ -32,12 +32,13 @@ local PERIODICS = {
 }
 
 -- create a new RTU session
----@param id integer
----@param in_queue mqueue
----@param out_queue mqueue
----@param advertisement table
----@param facility facility
-function rtu.new_session(id, in_queue, out_queue, advertisement, facility)
+---@param id integer session ID
+---@param in_queue mqueue in message queue
+---@param out_queue mqueue out message queue
+---@param timeout number communications timeout
+---@param advertisement table RTU device advertisement
+---@param facility facility facility data table
+function rtu.new_session(id, in_queue, out_queue, timeout, advertisement, facility)
     local log_header = "rtu_session(" .. id .. "): "
 
     local self = {
@@ -50,7 +51,7 @@ function rtu.new_session(id, in_queue, out_queue, advertisement, facility)
         seq_num = 0,
         r_seq_num = nil,
         connected = true,
-        rtu_conn_watchdog = util.new_watchdog(3),
+        rtu_conn_watchdog = util.new_watchdog(timeout),
         last_rtt = 0,
         -- periodic messages
         periodics = {

supervisor/session/svsessions.lua

@@ -2,6 +2,8 @@ local log         = require("scada-common.log")
 local mqueue      = require("scada-common.mqueue")
 local util        = require("scada-common.util")
 
+local config      = require("supervisor.config")
+
 local facility    = require("supervisor.session.facility")
 local svqtypes    = require("supervisor.session.svqtypes")
 
@@ -292,7 +294,7 @@ function svsessions.establish_plc_session(local_port, remote_port, for_reactor,
             instance = nil  ---@type plc_session
         }
 
-        plc_s.instance = plc.new_session(self.next_plc_id, for_reactor, plc_s.in_queue, plc_s.out_queue)
+        plc_s.instance = plc.new_session(self.next_plc_id, for_reactor, plc_s.in_queue, plc_s.out_queue, config.PLC_TIMEOUT)
         table.insert(self.plc_sessions, plc_s)
 
         local units = self.facility.get_units()
@@ -329,7 +331,7 @@ function svsessions.establish_rtu_session(local_port, remote_port, advertisement
         instance = nil  ---@type rtu_session
     }
 
-    rtu_s.instance = rtu.new_session(self.next_rtu_id, rtu_s.in_queue, rtu_s.out_queue, advertisement, self.facility)
+    rtu_s.instance = rtu.new_session(self.next_rtu_id, rtu_s.in_queue, rtu_s.out_queue, config.RTU_TIMEOUT, advertisement, self.facility)
     table.insert(self.rtu_sessions, rtu_s)
 
     log.debug("established new RTU session to " .. remote_port .. " with ID " .. self.next_rtu_id)
@@ -359,7 +361,7 @@ function svsessions.establish_coord_session(local_port, remote_port, version)
             instance = nil  ---@type coord_session
         }
 
-        coord_s.instance = coordinator.new_session(self.next_coord_id, coord_s.in_queue, coord_s.out_queue, self.facility)
+        coord_s.instance = coordinator.new_session(self.next_coord_id, coord_s.in_queue, coord_s.out_queue, config.CRD_TIMEOUT, self.facility)
         table.insert(self.coord_sessions, coord_s)
 
         log.debug("established new coordinator session to " .. remote_port .. " with ID " .. self.next_coord_id)

supervisor/startup.lua

@@ -14,7 +14,7 @@ local svsessions = require("supervisor.session.svsessions")
 local config     = require("supervisor.config")
 local supervisor = require("supervisor.supervisor")
 
-local SUPERVISOR_VERSION = "beta-v0.11.1"
+local SUPERVISOR_VERSION = "beta-v0.11.2"
 
 local print = util.print
 local println = util.println
@@ -30,6 +30,12 @@ local cfv = util.new_validator()
 cfv.assert_port(config.SCADA_DEV_LISTEN)
 cfv.assert_port(config.SCADA_SV_LISTEN)
 cfv.assert_type_int(config.TRUSTED_RANGE)
+cfv.assert_type_num(config.PLC_TIMEOUT)
+cfv.assert_min(config.PLC_TIMEOUT, 1)
+cfv.assert_type_num(config.RTU_TIMEOUT)
+cfv.assert_min(config.RTU_TIMEOUT, 1)
+cfv.assert_type_num(config.CRD_TIMEOUT)
+cfv.assert_min(config.CRD_TIMEOUT, 1)
 cfv.assert_type_int(config.NUM_REACTORS)
 cfv.assert_type_table(config.REACTOR_COOLING)
 cfv.assert_type_str(config.LOG_PATH)