GitHub/Basalt
1
0
Fork 0
Code Issues 28 Pull Requests 3 Actions Packages Projects Releases 9 Wiki Activity

deprecated isMoveable and setMoveable #6

Merged
Samkist merged 1 commits from samkist-deprecate-isMoveable-and-setMoveable into master 2022-05-20 02:01:18 +08:00
Conversation 5 Commits 1 Files Changed 1 +10 -1
Samkist commented 2022-05-20 01:20:17 +08:00 (Migrated from github.com)
Copy Link

I deprecated isMoveable and setMoveable in favor of isMovable and setMovable as the original ones are spelled incorrectly, and it could lead to mistakes in code

I deprecated isMoveable and setMoveable in favor of isMovable and setMovable as the original ones are spelled incorrectly, and it could lead to mistakes in code
NoryiE (Migrated from github.com) reviewed 2022-05-20 01:20:17 +08:00
Samkist (Migrated from github.com) reviewed 2022-05-20 01:20:49 +08:00
source/Frame.lua
@@ -84,3 +85,4 @@
barTextcolor = colors.black,
barText = "New Frame",
barTextAlign = "left",
isMovable = false,
Samkist (Migrated from github.com) commented 2022-05-20 01:20:49 +08:00
Copy Link

added isMovable variable

added isMovable variable
Samkist (Migrated from github.com) reviewed 2022-05-20 01:21:53 +08:00
source/Frame.lua
@@ -78,12 +78,15 @@ local function Frame(name, parent)
return false
end
---@class Frame
Samkist (Migrated from github.com) commented 2022-05-20 01:21:53 +08:00
Copy Link

added @class annotation to frame object for emmy lua based language server users e.g., sumneko, IntelliJ Emmy Lua

added `@class` annotation to frame object for emmy lua based language server users _e.g., sumneko, IntelliJ Emmy Lua_
Samkist (Migrated from github.com) reviewed 2022-05-20 01:22:19 +08:00
source/Frame.lua
@@ -85,2 +86,4 @@
barText = "New Frame",
barTextAlign = "left",
isMovable = false,
---@deprecated deprecated in favor of Frame#isMovable
Samkist (Migrated from github.com) commented 2022-05-20 01:22:19 +08:00
Copy Link

added @deprecated notice for emmy lua users, provides helpful comments when typing the function

added `@deprecated` notice for emmy lua users, provides helpful comments when typing the function
Samkist (Migrated from github.com) reviewed 2022-05-20 01:22:35 +08:00
source/Frame.lua
@@ -158,4 +168,3 @@
showBar = function(self, showIt)
self.barActive = showIt or not self.barActive
self:setVisualChanged()
Samkist (Migrated from github.com) commented 2022-05-20 01:22:34 +08:00
Copy Link

added new setMovable global function assignment

added new `setMovable` global function assignment
Sign in to join this conversation.
Reviewers
No Reviewers
NoryiE
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GitHub
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GitHub/Basalt#6
No description provided.
Delete Branch "samkist-deprecate-isMoveable-and-setMoveable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?