GitHub/Basalt
1
0
Fork 0
Code Issues 28 Pull Requests 3 Actions Packages Projects Releases 9 Wiki Activity

deprecated isMoveable and setMoveable #6

Merged
Samkist merged 1 commits from samkist-deprecate-isMoveable-and-setMoveable into master 2022-05-20 02:01:18 +08:00
Conversation 5 Commits 1 Files Changed 1 +10 -1
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source/Frame.lua
View File

@@ -78,12 +78,15 @@ local function Frame(name, parent)
return false return false
end end
---@class Frame
Samkist commented 2022-05-20 01:21:53 +08:00 (Migrated from github.com)
Review
Copy Link

added @class annotation to frame object for emmy lua based language server users e.g., sumneko, IntelliJ Emmy Lua

added `@class` annotation to frame object for emmy lua based language server users _e.g., sumneko, IntelliJ Emmy Lua_
object = { object = {
barActive = false, barActive = false,
barBackground = colors.gray, barBackground = colors.gray,
barTextcolor = colors.black, barTextcolor = colors.black,
barText = "New Frame", barText = "New Frame",
barTextAlign = "left", barTextAlign = "left",
isMovable = false,
Samkist commented 2022-05-20 01:20:49 +08:00 (Migrated from github.com)
Review
Copy Link

added isMovable variable

added isMovable variable
---@deprecated deprecated in favor of Frame#isMovable
Samkist commented 2022-05-20 01:22:19 +08:00 (Migrated from github.com)
Review
Copy Link

added @deprecated notice for emmy lua users, provides helpful comments when typing the function

added `@deprecated` notice for emmy lua users, provides helpful comments when typing the function
isMoveable = false, isMoveable = false,
getType = function(self) getType = function(self)
@@ -149,13 +152,19 @@ local function Frame(name, parent)
return self return self
end; end;
setMovable = function(self, movable)
self.isMovable = movable or not self.isMovable
self:setVisualChanged()
return self;
end;
---@deprecated deprecated in favor of @see Frame#setMovable
setMoveable = function(self, moveable) setMoveable = function(self, moveable)
self.isMoveable = moveable or not self.isMoveable self.isMoveable = moveable or not self.isMoveable
self:setVisualChanged() self:setVisualChanged()
return self; return self;
end; end;
showBar = function(self, showIt) showBar = function(self, showIt)
self.barActive = showIt or not self.barActive self.barActive = showIt or not self.barActive
self:setVisualChanged() self:setVisualChanged()