GitHub/Basalt
1
0
Fork 0
Code Issues 28 Pull Requests 3 Actions Packages Projects Releases 9 Wiki Activity

Refactor reactive framework #85

Merged
thesabinelim merged 5 commits from reactive-refactors into master 2023-05-18 02:02:29 +08:00
Conversation 0 Commits 5 Files Changed 3 +110 -151
thesabinelim commented 2023-05-18 01:51:56 +08:00 (Migrated from github.com)
Copy Link

Removed most object-specific extensions in order to produce a more agnostic framework.

Also allows for reactive props to be passed to loadLayout() in imperative code, as long as they're wrapped in functions.

Also removes most specific event registration functions in favour of a generic one that looks for properties starting with "on". It would be worth having another look at this in future to determine a better way, but for now this avoids needing to hard code for each object.

Removed most object-specific extensions in order to produce a more agnostic framework. Also allows for reactive props to be passed to loadLayout() in imperative code, as long as they're wrapped in functions. Also removes most specific event registration functions in favour of a generic one that looks for properties starting with "on". It would be worth having another look at this in future to determine a better way, but for now this avoids needing to hard code for each object.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GitHub
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GitHub/Basalt#85
No description provided.
Delete Branch "reactive-refactors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?